Base Simplification & Fixes #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some other work to bases, but decided to go back and put this in first, since it simplifies things later on. |
This was referenced Oct 13, 2024
|
Seeking input on one thing. Should we use half and quarter bin sizes on all axes, or only the one which is fractional. Example using a bin size of [2.5, 2]: Current: Alternative: |
* Fixes CI not running. * Allows markdown files to have hard linebreaks. * Ads additional checks.
This fixes a compatibility issue when using fractional grid sizes.
If someone wants to make custom sized grid bins, they can pass in custom grid_dimensions.
EmperorArthur
force-pushed
the
base_updates
branch
from
d4b5b1c to
adbad75
Compare
Ruudjhuu
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where half and quarter sized bins were the wrong size, since gap spacing was not kept constant.
Gridfinity bases now always automatically handle half and quarter units. Removing the confusing "div_base_x" and "div_base_y". If they were left to their default value of 1, half sized bins would not work correctly, and users would be confused as to why.