Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-Calculate Stacking Lip Fillet #215

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Auto-Calculate Stacking Lip Fillet #215

merged 4 commits into from
Oct 4, 2024

Conversation

EmperorArthur
Copy link
Collaborator

@EmperorArthur EmperorArthur commented Sep 2, 2024 •
edited
Loading

Calculates the fillet position for the stacking lip, instead of relying on the h_lip magic number.

Other Changes

  • Adjusted the stacking lip variables to match the baseplate ones in "standard.scad".
  • Bug Fix: When "gridz_define=2" and "style_lip=1" the bin would be 3.548mm shorter than expected.
  • Bug Fix: When "style_lip=2" bins would be 0.852mm shorter than the specification expects.
  • Bug Fix: Documentation in gridfinity-rebuilt-bins.scad incorrectly stated the stacking lip height was 3.8mm.

Related to, and may close:

@EmperorArthur
Caculate stacking lip support based on an angle
b4061d4 
Removes the need for a magic constant.
@EmperorArthur
Add an image explaining the variables for stacking lip
a0f7ad8
@EmperorArthur
Add an affine_scale command
dc4069b
@EmperorArthur
Switch stacking lip constants to the same format as baseplate constants
c34de9b 
This increases readability and usability, while also being more compact.

Also updated documentation in gridfinity-rebuilt-bins to explain how heights are calculated.
@EmperorArthur EmperorArthur merged commit f6ae092 into kennetek:main Oct 4, 2024
1 check passed
@EmperorArthur EmperorArthur deleted the update_wall_profile branch October 4, 2024 05:45
@EmperorArthur EmperorArthur mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruudjhuu Ruudjhuu Ruudjhuu approved these changes

@kennetek kennetek Awaiting requested review from kennetek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmperorArthur @Ruudjhuu