Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix magnet hole position on 1/2 grid bins #150

Closed
wants to merge 1 commit into from

Conversation

Wuppdich
Copy link

@Wuppdich Wuppdich commented Jan 23, 2024

fixes #149, possibly also fixes #105.

magnet hole positions now respect the calculated or manually set grid division

Bildschirmfoto vom 2024-01-23 12-44-47e

only looks good on 1/2 grid bins. smaller divisions are too small for magnets.

image

only looks great on 1/2 grid bins. smaller divisions are too small for magnets.
@Wuppdich Wuppdich changed the title fix magnet hole position on 1/n grid bins fix magnet hole position on 1/2 grid bins Jan 23, 2024
w33ble added a commit to w33ble/gridfinity-rebuilt-openscad that referenced this pull request Feb 9, 2024
w33ble added a commit to w33ble/gridfinity-rebuilt-openscad that referenced this pull request Feb 9, 2024
@Ruudjhuu
Copy link
Collaborator

Magnetholes create 4 holes per grid unit afaik. I see two in your pictures. Could you enlighten me on what I'm missing? Does this still work with larger than normal grid units and normal grid units?

w33ble added a commit to w33ble/gridfinity-rebuilt-openscad that referenced this pull request Feb 16, 2024
w33ble added a commit to w33ble/gridfinity-rebuilt-openscad that referenced this pull request Mar 27, 2024
@Wuppdich
Copy link
Author

The magnet holes are simply rotated with offset around an origin, creating a square pattern:

grafik
grafik

This results in non-equal base-divisions using the y-division to determine the edge-lenght of the square magnet-hole arrangement!

grafik

My solution creates ugly geometry when y-base-division != 1, which i didn't notice before. (see image above with div_base_y set to 2)

Normal grid units are not affected by this change:

grafik

I don't know how to create larger than normal grid units. Setting div_base_x or y to 0.5 acts like it's been set to 1.

As my little hack is sufficient for my own needs, but not fit for general application and i have no interest in changing the underlying logic to properly accommodate non-square base-divisions, I am going to close this PR.

@Wuppdich Wuppdich closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printable slit not working properly with non-integer bin sizes holes got broken
2 participants