Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace, add pre-commit and CI workflow to check whitespace #128

Merged
merged 7 commits into from
Jan 6, 2024

Conversation

smkent
Copy link
Contributor

@smkent smkent commented Sep 22, 2023

This model is so useful! I've been printing a lot of Gridfinity bins and am starting to customize my own. That's led me to dig through the OpenSCAD code to make customizations.

To make development easier, this PR:

  • Adds whitespace fixes -- removes trailing whitespace and adds newlines at the end of all files
  • Adds pre-commit to fix these issues at commit time
    • A developer can enable these hooks with pre-commit install within their cloned repository
  • Adds a GitHub Actions workflow to run pre-commit's whitespace checks on PRs, so all new code will be consistent

@smkent
Copy link
Contributor Author

smkent commented Sep 22, 2023

See this test PR in my fork and workflow run for an example of the GitHub Action being added.

@Ruudjhuu Ruudjhuu requested a review from kennetek October 25, 2023 13:18
Conflicts:
	gridfinity-rebuilt-utility.scad
@smkent
Copy link
Contributor Author

smkent commented Dec 30, 2023

Hi, is there interest in merging this PR? Thanks!

@Ruudjhuu
Copy link
Collaborator

Ruudjhuu commented Jan 6, 2024

Is there a way to show more information for the CI run? like line numbers?

@smkent
Copy link
Contributor Author

smkent commented Jan 6, 2024

Is there a way to show more information for the CI run? like line numbers?

Yep! Updated. Check it out: https://github.com/kennetek/gridfinity-rebuilt-openscad/actions/runs/7432741288/job/20224893804?pr=128

@Ruudjhuu Ruudjhuu merged commit e7478a7 into kennetek:main Jan 6, 2024
1 check passed
@smkent smkent deleted the pre-commit branch January 6, 2024 17:35
@smkent
Copy link
Contributor Author

smkent commented Jan 6, 2024

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants