Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for pdbreaper types and fix validation bugs #122

Merged
merged 9 commits into from
Dec 9, 2023
Merged

Add unit tests for pdbreaper types and fix validation bugs #122

merged 9 commits into from
Dec 9, 2023

Conversation

tekenstam
Copy link
Member

@tekenstam tekenstam commented Oct 7, 2023 •
edited
Loading

  • Add unit tests
  • Fix validation of ReapNotReadyThreshold
  • Fix validation of K8sConfigPath

@tekenstam tekenstam requested a review from a team as a code owner October 7, 2023 00:30
tekenstam and others added 3 commits October 6, 2023 17:37
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c37b390) 61.42% compared to head (0275622) 64.13%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   61.42%   64.13%   +2.71%     
==========================================
  Files          11       11              
  Lines        2136     2136              
==========================================
+ Hits         1312     1370      +58     
+ Misses        727      669      -58     
  Partials       97       97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tekenstam
Fix bug and add tests
69bcc24 
Signed-off-by: Todd Ekenstam <[email protected]>
@tekenstam tekenstam changed the title Add unit tests for pdbreaper types Add unit tests for pdbreaper types and fix validation bugs Oct 7, 2023
@tekenstam tekenstam merged commit 12148f5 into master Dec 9, 2023
4 checks passed
@tekenstam tekenstam deleted the pdbreaper-tests branch December 9, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tekenstam