-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for URL wildcards and exact URL #9835
base: develop
Are you sure you want to change the base?
Add support for URL wildcards and exact URL #9835
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TODO: Check if using https://doc.qt.io/qt-6/qregularexpression.html#wildcardToRegularExpression is preferred after Qt6 upgrade. Qt5 does not support |
Oh nice that will likely replace one of our tools functions. |
229704d
to
9ab03a5
Compare
@varjolintu can you rebase this onto develop? Also want to make the change that wildcards are only valid in the "extra urls" and not the main url so click to open will still work. |
This change would be very welcome. I was also concerned about this if wildcards are used in the main URLs. |
9ab03a5
to
55ddd9d
Compare
Adds support for URL wildcards and exact URL if the address is wrapped insinde
"
e.g."https://example.com/page.php"
. Without wildcards, URL's are handled normally with the old/current implementation.The wildcards can be used freely, and some example addresses are:
https://*.example.com/page/*
https://192.*.168.1/
subdomain.of.*.example.com/page/*/login
Fixes #3718.
Testing strategy
Manually, and added automatic tests.
Type of change