Implement Secure Input Mode on macOS #11623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
reviewed
Jan 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11623 +/- ##
===========================================
- Coverage 63.95% 63.95% -0.00%
===========================================
Files 364 364
Lines 38302 38307 +5
===========================================
+ Hits 24496 24498 +2
- Misses 13806 13809 +3 ☔ View full report in Codecov by Sentry. |
* Fixes #4738 * Also fixes flaky handling of caps lock detection events
droidmonkey
force-pushed
the
fix/macos-input-security
branch
from
965cf58 to
318c862
Compare
phoerious
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
BEFORE / AFTER screen recording using Typinator as the canary:
2025-01-04_09-44-17.mp4
Testing strategy
Tested on macOS 15.1.1 using Typinator as a canary to see if keystrokes are visible to external apps granted the accessibility permission. Also tested non-password fields to demonstrate that secure input mode was properly disabled when focus on a password field is lost.
Type of change