Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Qt >= 5.12 #10900

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Require Qt >= 5.12 #10900

merged 1 commit into from
Jun 22, 2024

Conversation

c4rlo
Copy link
Contributor

@c4rlo c4rlo commented Jun 14, 2024 •
edited
Loading

Bump the minimum required Qt version up to 5.12, as per #10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work (and at some point, INSTALL.md stated that 5.9.5 was the minimum).

With this, we are able to remove a whole bunch of #ifdef'd code.

Testing strategy

All tests continue to pass, except for:

QFATAL : TestGui::testRemoteSyncDatabaseRequiresPassword() Received signal 11
         Function time: 658ms Total time: 5010ms
FAIL!  : TestGui::testRemoteSyncDatabaseRequiresPassword() Received a fatal error.
   Loc: [Unknown file(0)]

However, this also happens on the develop branch.

Type of change

  • ✅ Refactor (significant modification to existing code)

@c4rlo
Copy link
Contributor Author

c4rlo commented Jun 14, 2024

Ubuntu test failure seems unrelated:

19:02:41   FAIL!  : TestCli::testClip() '(isTotp(clipboard->text()))' returned FALSE. ()
19:02:41      Loc: [/opt/buildagent/work/c401303cba1b4098/tests/TestCli.cpp(680)]

@droidmonkey droidmonkey added this to the v2.8.0 milestone Jun 16, 2024
@c4rlo @droidmonkey
Require Qt >= 5.12
465d959 
Bump the minimum required Qt version up to 5.12, as per
keepassxreboot#10859 (comment).
Previously, the minimum version was 5.2.0 based on the CMakeLists.txt
check, though it's unclear if such old versions would actually work.

With this, we are able to remove a whole bunch of #ifdef'd code.
@droidmonkey droidmonkey merged commit 07f565a into keepassxreboot:develop Jun 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@c4rlo @droidmonkey