Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passkeys: UI adjustments #10059

Merged

Conversation

varjolintu
Copy link
Member

Adjust the UI to be more consistent with each other, and fix some resizing issues.

Changes in this PR:

  • Change dialog titles with KeePassXC: to use KeePassXC - like everywhere else.
  • Show Relying Party instead of URL.
  • Use PlainText for Username and Relying Party.
  • Swap button positions in Import and Export dialogs to match these with other dialogs.

Screenshots

Old:
old_import_1
old_import_2
old_register
old_auth
New:
new_import_1
new_import_2
new_register
new_auth

Type of change

  • ✅ Refactor (significant modification to existing code)

@varjolintu varjolintu added this to the v2.8.0 milestone Nov 25, 2023
@droidmonkey
Copy link
Member

In the last dialog, what's the difference between the relying party in the text and the relying party (or url) in the selection box? Do we need to show it in both places? I think the way passkeys work means you don't really have to think about relying party after registration.

@varjolintu
Copy link
Member Author

varjolintu commented Nov 25, 2023

In the last dialog, what's the difference between the relying party in the text and the relying party (or url) in the selection box? Do we need to show it in both places? I think the way passkeys work means you don't really have to think about relying party after registration.

The selection box shows the entry title and username. Of course user can change the title, but it has the Relying Party by default when creating a Passkey. The dialog should show either URL or the Relying Party. I chose the latter.

@droidmonkey
Copy link
Member

Ok the most important part is the title and username since relying party should always be the same. So if you had multiple keys to choose from you would see a bunch of repeating relying party lines.

@droidmonkey droidmonkey force-pushed the fix/passkeys_ui_adjustments branch from d95bd70 to eaa57fe Compare January 6, 2024 17:38
@droidmonkey droidmonkey merged commit 6d19ab8 into keepassxreboot:develop Jan 6, 2024
10 of 11 checks passed
@varjolintu varjolintu deleted the fix/passkeys_ui_adjustments branch January 6, 2024 18:49
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Browser feature: Passkeys pr: backported Pull request backported to previous release pr: refactoring Pull request that refactors code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants