Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for the UltraStarknetHonk #287

Merged
merged 25 commits into from
Jan 24, 2025
Merged

Adds support for the UltraStarknetHonk #287

merged 25 commits into from
Jan 24, 2025

Conversation

raugfer
Copy link
Collaborator

@raugfer raugfer commented Jan 7, 2025 •
edited by feltroidprime
Loading

@feltroidprime
Copy link
Collaborator

feltroidprime commented Jan 7, 2025 •
edited
Loading

garaga/tests/hydra/circuits/test_honk.py

Line 19 in 3c87bb0

def test_sumcheck_circuit():

Please add a test for the Starknet flavour similar to this one (this is the verifier algo, this should actually renamed to test_verify_honk_proof)

If bb verify worked, this should work as well (almost) seamlessly

raugfer and others added 20 commits January 7, 2025 17:49
@raugfer
Adds the example for UltraStarknetHonk proof
578dc9b
@raugfer
Parameterizes test_sumcheck_circuit to also test UltraStarknetHonk
e559bea
@raugfer
Adds missing pytest import
d881cda
@raugfer
Fixes StarknetPoseidonTranscript implementation
91be12a
@raugfer
Fixes update() method for the UltraStarknetHonk transcript class
a59791f
@raugfer
Renames test_sumcheck_circuit to test_verify_honk_proof
63b04ab
@raugfer
Adds honk_transcript.cairo generalizing noir transcript for both kecc…
06b7af5 
…ak and starknet
@raugfer
Fixes honk transcript by moving ke_le_out_to_ch_be into keccak.digest()
e873be4
@raugfer
Adds honk_transcript as public module of noir.cairo
70f01e2
@raugfer
Updates honk generator to use the new honk_verifier.cairo implementation
02fd13d
@raugfer
Updates noir_ultra_keccak_honk_example to use the new honk_verifier.c…
31cdbb3 
…airo implementation
@raugfer
Adds the noir_ultra_starknet_honk_example folder to src/contracts
7ac2dcb
@raugfer
Adds e2e test for noir_ultra_starknet_honk_example
23e77d4
@raugfer
Adds support for noir_ultra_starknet_honk_example to tools/make scripts
fa34622
@raugfer
Update main of generator_honk.py to produce both keccak and starknet …
0f5c48e 
…honk flavors
@raugfer
Adds ultra_starknet_honk transcript test case
8ea6d94
@raugfer
Applies scarb fmt
9eef2b8
@raugfer
Adds missing import of StarknetHasherState
6f5d0ac
@feltroidprime
Return keccak transcript perf to previous.
cc18777
@feltroidprime
const init for poseidon
6fd32b8
@feltroidprime feltroidprime marked this pull request as ready for review January 11, 2025 11:46
@feltroidprime feltroidprime self-requested a review as a code owner January 11, 2025 11:46
@feltroidprime feltroidprime merged commit f5921e0 into keep-starknet-strange:main Jan 24, 2025
27 checks passed
@raugfer raugfer deleted the ultra-starknet-honk branch January 24, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feltroidprime feltroidprime feltroidprime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raugfer @feltroidprime