Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inconsistent navigation links in documentation #19

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Jan 8, 2025

Signed-off-by: ravi_kumar_pilla <[email protected]>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review January 8, 2025 06:54
@ravi-kumar-pilla
Copy link
Contributor Author

Hi @rashidakanchwala ,

This is a small change to the nav link but I would like to know how to test this locally (i.e., getting a preview of the docs or may be layout.html).

After the tests, the CI adds a📚 Documentation preview 📚: https://kedro-sphinx-theme--19.org.readthedocs.build/en/19/ which seems broken. Also, the highlightActiveLink function does not highlight kedro-viz for the first time. I wanted to fix this and could not find any doc on testing this locally. Happy to connect when you have some time.

Thank you

@astrojuanlu
Copy link
Member

Yeah ignore the Documentation preview link, this repo itself doesn't have docs

I think this is the way to go

Copy link
Collaborator

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hope this works.

@ravi-kumar-pilla ravi-kumar-pilla merged commit 57d757b into main Jan 13, 2025
7 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the chore/clean-nav-link branch January 13, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent navigation links in documentation
3 participants