Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add beanstalkd scaler docs #1454

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add beanstalkd scaler docs #1454

wants to merge 10 commits into from

Conversation

sbarnesthornton
Copy link

@sbarnesthornton sbarnesthornton commented Aug 15, 2024 •
edited by tomkerkhove
Loading

Adds docs regarding the beanstalkd scaler introduced in #5901.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#5901
Relates to kedacore/keda#6081

Add beanstalkd scaler docs
1df4f82 
Signed-off-by: Sam Barnes-Thornton <[email protected]>
@sbarnesthornton sbarnesthornton requested a review from a team as a code owner August 15, 2024 16:21
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 26bd953
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/670391d9dabae1000870fb0e
😎 Deploy Preview https://deploy-preview-1454--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sbarnesthornton sbarnesthornton mentioned this pull request Aug 15, 2024
Open
6 tasks
Sam Barnes-Thornton added 2 commits August 15, 2024 16:29
Add Go file
75b1df6 
Signed-off-by: Sam Barnes-Thornton <[email protected]>
Add timeout to docs
9a575f5 
Signed-off-by: Sam Barnes-Thornton <[email protected]>
Add timeout to specification
bbbc474 
Signed-off-by: Sam Barnes-Thornton <[email protected]>
tomkerkhove
tomkerkhove approved these changes Aug 20, 2024
View reviewed changes
content/docs/2.15/scalers/beanstalkd.md Outdated Show resolved Hide resolved
Move beanstalkd docs to 2.16
a38b21c 
Signed-off-by: Sam Barnes-Thornton <[email protected]>
@sbarnesthornton
Copy link
Author

The test deployment preview is failing after I have changed the version to be 2.16, which seems potentially something to do with caching as it is still looking for the docs in 2.15. I'm not sure how to sort this, but it was working before the move to 2.16.

JorTurFer
JorTurFer approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

Could you add the page to this file? https://github.com/kedacore/keda-docs/blob/main/.htmltest.yml

As the scaler doesn't appear in v2.15, the links checker is detecting it as failure

Add missing 2.15 version to test ignores
26bd953 
Signed-off-by: Sam Barnes-Thornton <[email protected]>
@sbarnesthornton
Copy link
Author

Page has been added to the test ignores file as instructed. Deploy tests all seem to pass now, so should be good to go. Thanks for all the help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbarnesthornton @tomkerkhove @JorTurFer