Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Procedure for Setting up a Scaler #1408

Closed
wants to merge 32 commits into from
Closed

Conversation

shubhusion
Copy link

Provide a description of what has been changed

Created a Procedure for Setting up a Scaler in KEDA

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1368

@shubhusion shubhusion requested a review from a team as a code owner June 16, 2024 19:17
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Jun 16, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 0a2f1be
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/667e6f777f109d0008901013
😎 Deploy Preview https://deploy-preview-1408--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shubhusion
Copy link
Author

shubhusion commented Jun 17, 2024

@zroubalik, the above checks are failing. Could you please guide me on how to resolve them?

@tomkerkhove
Copy link
Member

This is because the build is failing, see: #1408 (comment)

@shubhusion
Copy link
Author

This is because the build is failing, see: #1408 (comment)

build is failing bacause it is not able to find the images I had attached as output.

JorTurFer and others added 22 commits June 28, 2024 13:29
Signed-off-by: Alon Gluz <[email protected]>
Signed-off-by: shubhusion <[email protected]>
…equired field (kedacore#1395)

* Move queryParameters down to the optional field list

Signed-off-by: Alec Hinh <[email protected]>

* Move the query parameters list entries down to optional in the other versions

Signed-off-by: Alec Hinh <[email protected]>

---------

Signed-off-by: Alec Hinh <[email protected]>
Signed-off-by: shubhusion <[email protected]>
* Feat: Provide filtering capabilities for scalers

Signed-off-by: thisisobate <[email protected]>

* chore: provide filter button on mobile

Signed-off-by: thisisobate <[email protected]>

* chore: reduce spacing between filter and scaler cards

Signed-off-by: thisisobate <[email protected]>

* chore: improve filter logic to use new model

Signed-off-by: thisisobate <[email protected]>

* chore: reorder filter options

Signed-off-by: thisisobate <[email protected]>

* chore: nit fix

Signed-off-by: thisisobate <[email protected]>

---------

Signed-off-by: thisisobate <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
shubhusion and others added 8 commits June 28, 2024 13:29
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: Joel Smith <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@shubhusion
Copy link
Author

@tomkerkhove I will make another PR. I am closing it.

@shubhusion shubhusion closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a Procedure for Setting Up a Scaler
9 participants