fix(merge): updates MergeAppend function for booleans with False values #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eminaktas
force-pushed
the
fix/merge-append
branch
from
72fe42a
to
35bb39e
Compare
Fixes kcl-lang#248 and kcl-lang#250 Signed-off-by: Emin Aktas <[email protected]>
eminaktas
force-pushed
the
fix/merge-append
branch
from
35bb39e
to
c1b1895
Compare
|
Thank you! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248 and #250
1. Please confirm that you have read the document before PR submitted
2. Contact Information(Optional)
If it is convenient, please provide your contact information so we can reach you when processing the PR: