Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed an issue where the 'full_name' in kcl.mod.lock changed when there was already a local dependency #487

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…n there was already a local dependency

Signed-off-by: zongz <[email protected]>
@zong-zhe zong-zhe added the bug Something isn't working label Sep 20, 2024
@zong-zhe zong-zhe requested a review from Peefy September 20, 2024 06:43
@zong-zhe zong-zhe self-assigned this Sep 20, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024

Pull Request Test Coverage Report for Build 10955070417

Details

  • 12 of 15 (80.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 42.128%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/package/modfile.go 9 12 75.0%
Files with Coverage Reduction New Missed Lines %
pkg/package/modfile.go 1 41.06%
Totals Coverage Status
Change from base Build 10888425126: 0.2%
Covered Lines: 3465
Relevant Lines: 8225

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 72dd5e0 into main Sep 20, 2024
6 checks passed
@Peefy Peefy deleted the fix-add-bug branch September 20, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants