Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change eagerly evaluated to lazy evaluated #1522

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 25, 2024

change eagerly evaluated unwrap_or to lazy evaluated unwrap_or_else

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa changed the title chore: change eagerly evaluated unwrap_or to lazy evaluated `unwrap chore: change eagerly evaluated to lazy evaluated Jul 25, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10092138427

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.317%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/config.rs 3 4 75.0%
Totals Coverage Status
Change from base Build 10076748726: 0.0%
Covered Lines: 54031
Relevant Lines: 76839

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

@Peefy Peefy merged commit 3cbb93f into kcl-lang:main Jul 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Significant performance issue in LSP resolver
3 participants