Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix check config visited entry.value twice #1498

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 15, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/config.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix check config visited entry.value twice

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM.

Grammar CI failed.

@He1pa He1pa force-pushed the fix_resolver_check_config branch from e61bd29 to ff51c80 Compare July 15, 2024 10:59
@coveralls
Copy link
Collaborator

coveralls commented Jul 15, 2024

Pull Request Test Coverage Report for Build 9938182092

Details

  • 11 of 15 (73.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 71.765%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/config.rs 11 15 73.33%
Totals Coverage Status
Change from base Build 9926941103: 0.002%
Covered Lines: 57228
Relevant Lines: 79744

💛 - Coveralls

@Peefy Peefy merged commit 4e43775 into kcl-lang:main Jul 15, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Significant performance issue in LSP resolver
3 participants