Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUBLIC-2035 Update spec.json to point to release for taxonomy_re_api #344

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bio-boris
Copy link
Collaborator

@bio-boris bio-boris commented May 13, 2022

Description of PR purpose/changes

Testing Instructions

  • Details for how to test the PR:
  • Tests pass in Travis-CI and locally

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, including updating the README with app information changes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

@bio-boris bio-boris changed the title Create spec.json PUBLIC-2035 Update spec.json to point to release for taxonomy_re_api May 13, 2022
@bio-boris bio-boris requested a review from n1mus May 13, 2022 04:42
@sonarcloud
Copy link

sonarcloud bot commented May 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #344 (b649344) into master (3727159) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files          17       17           
  Lines        1826     1826           
=======================================
  Hits         1299     1299           
  Misses        527      527           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d67ff71...b649344. Read the comment docs.

Copy link

@n1mus n1mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@n1mus
Copy link

n1mus commented May 13, 2022

Oh yeah we should just be sure OLD taxAPI is released first

@bio-boris bio-boris marked this pull request as ready for review June 1, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants