fix cross join test and add docs #776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wd60622
reviewed
Jan 18, 2024
|
|
||
| self.assertEqual(expected, str(query)) | ||
|
|
||
| with self.subTest("join function"): | ||
| query = Query.from_(self.table0).cross_join(self.table1).on(self.table0.foo == self.table1.bar).select("*") | ||
| query = Query.from_(self.table0).cross_join(self.table1).cross().select("*") |
There was a problem hiding this comment.
This might be an API design item, but why does cross and cross_join have to be called?
Does cross take arguments?
|
I don't know why it is like this since I didn't implement this, but as pypika is now this is AFAIK the correct way to do a cross join. |
Do you think omitting it is more intuitive? If so, feel free to make a change in that direction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the cross join test (cross joins don't have an on clause) and adds documentation that you need to use .cross() after a cross_join().