This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Call uniq before printing errors and warnings #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting a lot of duplicate warning output from cocoapod dependencies, seems like the warning got added again every time the file was imported or something. Using uniq seems to cut this down efficiently, actually improving performance. Unfortunately my builds are private so I can't link to them.
Old
14170-10398 = 3772 lines
2:31:58-2:31:44 = 14 seconds
New
10684-10408 = 276 lines
14:40:18-14:40:17 = 1 second
93% shorter and 93% faster