Temporary interface: Add fsm_determinise_with_config. #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works, but we may want to make some naming changes. I'd prefer to use a struct rather than a single parameter here -- as long as other fields have a sensible default when zeroed, the callers will only need to make the interface change once.
I think it's worth having some kind of limit here, since determinisation is most likely to have wide variation in resource usage.
errno
, likeE2BIG
.<function>_with_an_extra_configuration_struct
(fsm_determinise_with_config
?fsm_determinise_cfg
?) and keep both (and possibly add similar variants for other functions later), or just add astate_limit
param, but that would be my last choice.