print API: Box end_ids and end_id_count in a struct for callbacks. #497
Conversation
Move the end_id array and its count into a struct for state metadata, and rename access throughout to end_ids and end_id_count. Upcoming changes for eager output IDs will soon be passing more info to all of these callbacks, but only callers making use of those fields need to care. Instead of making callers add more `(void) param;` declarations all over the place to avoid warnings, just pass in a metadata struct pointer. Also, "count" is a pretty generic name and what it refers to will soon be ambiguous. This should not be a functional change on its own.
The IR struct is about to get another id & count pair. This loses storing the count as a 31-bit bitfield, but if the goal for that is saving memory then the ids array allocation could be replaced with a struct that contains the count, and then each IR without endids will save more space than the current approach.
| fsm_end_id_t *ids; /* NULL -> 0 */ | ||
| size_t count:31; // :31 for packing | ||
| struct ir_state_endids { | ||
| fsm_end_id_t *ids; /* NULL -> 0 */ |
There was a problem hiding this comment.
This loses the :31 for packing, but if the goal is to save memory per IR state, then this could instead be a separately allocated struct like struct ir_state_endids { size_t count; fsm_end_ids_t ids[]; } and states without endids (which will be most states) save storing the count entirely. Thoughts?
There was a problem hiding this comment.
No need, the packing isn't that important.
|
I also moved it into a struct in the IR, because the same issues apply there -- it's about to get a different ID type (eager output IDs) and "ids" and "count" bare are ambiguous. |
|
This failed due to the fuzzer hitting an unrelated bug, for |
|
I might come back and rename this, the names are all too verbose for me... |
katef
deleted the
sv/move-codegen-callback-metadata-args-into-struct
branch
Move the end_id array and its count into a struct for state metadata, and rename access throughout to end_ids and end_id_count.
Upcoming changes for eager output IDs will soon be passing more info to all of these callbacks, but only callers making use of those fields need to care. Instead of making callers add more
(void) param;declarations all over the place to avoid warnings, just pass in a metadata struct pointer. Also, "count" is a pretty generic name and what it refers to will soon be ambiguous.This should not be a functional change on its own, it's just clearing the way for new features.