Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AMBIG_MULTIPLE for llvm, Rust, go, and the vmops dump #486

Merged
merged 22 commits into from
Aug 16, 2024
Merged

Implement AMBIG_MULTIPLE for llvm, Rust, go, and the vmops dump #486

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
366fce6
Move out retlist construction.
katef Jul 27, 2024
684433c
Constuct retlist ahead of time for all vm-based formats.
katef Jul 28, 2024
5092212
Add AMBIG_MULTIPLE output for go.
katef Jul 28, 2024
7cdb00b
No need for the vmops_dialect enum here.
katef Jul 31, 2024
7e970d7
Whitespace.
katef Jul 31, 2024
f2bae91
Bugfix; 1 means VM_END_SUCC here.
katef Aug 2, 2024
ac4a66a
Ensure we don't pass NULL to memcmp()
katef Aug 2, 2024
e484294
Support for enids for the vmops output.
katef Aug 2, 2024
2698127
First cut at AMBIG_MULTIPLE for llvm.
katef Aug 5, 2024
7426501
Rework stop: to index into an array for return values.
katef Aug 6, 2024
f69dbfc
Don't use `undef` for values the caller is expected to not access, us…
katef Aug 6, 2024
292fd1c
Split overriding comments to a separate hook.
katef Aug 7, 2024
bb4e81d
No need to emit a bitmap here.
katef Aug 7, 2024
6c17934
Use id count to indicate match failure, and >= 0 means success.
katef Aug 7, 2024
c44bfd2
Clarification.
katef Aug 7, 2024
ba70069
Add AMBIG_MULTIPLE output for Rust.
katef Aug 7, 2024
218e90c
Factor out print_ret().
katef Aug 7, 2024
021d169
Merge branch 'main' into kate/more-multi
katef Aug 7, 2024
719b1b2
Whoops... wrong exit status.
katef Aug 11, 2024
690f0e2
Oops... this should've been done with the API change to return a bool.
katef Aug 12, 2024
0f4d838
Separate calling points for the comments hook.
katef Aug 14, 2024
ab0a411
Typo.
katef Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion include/fsm/print.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,17 @@ struct fsm_hooks {

/*
* Print an FSM to the given file stream. The output is written in the format
* specified.
* specified by the lang enum.
*
* Not all languages support all options, and fsm_print will ENOTSUP where
* these are not possible. This is different to when an option is possible
* but simply not yet implemented, where fsm_print() will print a message
* to stderr and exit.
*
* The code generation for the typical case of matching input require the FSM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo: "requires" (plural)

* to be a DFA, and will EINVAL if the FSM is not a DFA. As opposed to e.g.
* FSM_PRINT_API, which generates code for other purposes, and does not place
* particular expecations on the FSM.
*
* The output options may be NULL, indicating to use defaults.
*
Expand Down
Loading