Consolidate RE_EUNSUPPORTED syntax errors #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katef
force-pushed
the
kate/consolidate-unsupported
branch
from
c47df4c
to
c95d514
Compare
My thinking here is that we don't need to categorise these independently from anything else we consider unsupported, because to the caller the reason something is unsupported doesn't matter. This way there's only one situation for a caller to keep track of, and in particular to not need to remember to update whenever we introduce more unsupported things.
katef
force-pushed
the
kate/consolidate-unsupported
branch
from
3eec4f9
to
5592b40
Compare
katef
force-pushed
the
kate/consolidate-unsupported
branch
from
5592b40
to
61772d0
Compare
silentbicycle
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have two errors about unsupported situations found during AST analysis:
These are more specific than we need for a caller, and give a maintenance burden for when more would be introduced. So in this PR I'm rolling them up under the more general
RE_EUNSUPPORTEDcase.Any similar future ones can go under there too.
Now those two did not have an associated token (that is, they do not have
| RE_MARK). ButRE_EUNSUPPORTEDdoes. So in this PR I am also providing a position for the error (which is why I did #471 first).I'm blaming the entire string for this case (and would do for any other errors found through AST analysis), because we also construct ASTs from .fsm syntax. So it doesn't make sense to have AST nodes track lexical tokens for source position, because there isn't always a source.