Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-instate detecting ambiguous mappings in lx. #439

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Re-instate detecting ambiguous mappings in lx. #439

wants to merge 3 commits into from

Commits on Jul 20, 2023

  1. Re-instate detecting ambiguous mappings in lx. 

    Previously the conflicts were flagged inside of carryopaque,
but that was removed in 3d532ee. Now do it in its own pass,
called `ast_noteconflicts`.

Add a test (`tests/lxconflict/in0.lx` and `out0.err`).
    @silentbicycle
    silentbicycle committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    872131a View commit details
    Browse the repository at this point in the history

  2. Fix silly bug, caught by ASan.

    @silentbicycle
    silentbicycle committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6d3ec29 View commit details
    Browse the repository at this point in the history

  3. tests/lxconflict: Disable when running CI in (Makefile) mode. 

    We're trying to test lx's error output for ambiguity, so replacing
${LX} with "true; echo lx" obviously won't work, and it also breaks
the build in a really confusing way. Just skip it.
    @silentbicycle
    silentbicycle committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    da28efb View commit details
    Browse the repository at this point in the history