Disable multithreading in lx for now. #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running this in a loop:
$ while true; do sleep 0.1; ./build/bin/lx -l test < src/lx/lexer.lx \
&& echo ok; done
Produces a stream of intermittent failures. There appears to be
unsynchronized access to a shared/global resource, and races on
either `realloc`ing or `free`ing it can nondeterministically lead
to memory corruption.
For now, change to using only one thread -- issue #351 exists as a
reminder to-enable this once the underlying problem has been fixed.
katef
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running this in a loop:
Produces a stream of intermittent failures. There appears to be
unsynchronized access to a shared/global resource, and races on
either
reallocing orfreeing it can nondeterministically leadto memory corruption.
For now, change to using only one thread -- issue #351 exists as a
reminder to-enable this once the underlying problem has been fixed.