Import Cargo, first steps towards porting to Rust 🦀 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a shame, but gets in the way of porting to Rust.
… the partially linked .o files. This hopefully avoids an ld bug where `-undefined dynamic_lookup` doesn't work on MacOS, and also removes the need for programs to link both the C and Rust libraries directly.
|
Really porting to Rust? |
I'm unsure. at least for the moment, it's more work than I can take on, regardless of whether it's a good idea or not. So this PR isn't going anywhere for a while yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm introducing Cargo to the build. It's driven from the existing makefiles. This marks the start of porting to Rust by a piecemeal approach, so we'll have a hybrid codebase until that's completed.
I've added an
fsm_noopfunction written in Rust (called fromfsm_new), just to prove the linking here works.Currently the makefiles build libfsm.a from a single partially-linked libfsm.o. That single .o file is made by
ld -r -o libfsm.o *.o, effectively bundling together all the various .o files.In this PR I'm adding the Cargo-generated .a file to that list of sources for
ld -r. I think this depends on ld being able to see inside a .a file when invoked with -r for partial linking. This seems to work okay, at least on the ELF and Mach-O systems available in CI. Those are all I'm interested in for the moment.