Rewrite (?:|xyz) and (?:xyz|) to (?:xyz)?.
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katef
force-pushed
the
kate/rewrite-to-optional-alts
branch
from
f513fae
to
35cbb57
Compare
katef
commented
Sep 21, 2020
| @@ -317,6 +317,30 @@ rewrite_alt(struct ast_expr *n, enum re_flags flags) | |||
| return 1; | |||
| } | |||
|
|
|||
| if (n->u.alt.count == 2) { | |||
There was a problem hiding this comment.
@hvdijk points out that this would also apply for n > 2, which I hadn't thought of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps a little for rendering out to more natural regexp syntax.
For example: