Stop using exit in parser. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katef
reviewed
Apr 3, 2021
| if (error_count != 0) { | ||
| fprintf(stderr, "KGT: Exiting. %d errors reported\n", error_count); | ||
| exit(EXIT_FAILURE); | ||
| } |
There was a problem hiding this comment.
This is great work, thank you.
Do you think the queue is necessary? I'd only imagined kgt giving one error and exiting, I hadn't intended to attempt to recover and continue a parse. Have you seen multiple errors?
There was a problem hiding this comment.
Yes, multiple errors is possible.
You can try on:
https://arthursonzogni.com/Diagon/#Grammar
With input = iso-ebnf
a
output:
1:1:Syntax error: expected production rule assignment
1:1:Syntax error: expected production rule separator
With input = abnf
a = b
a = b
a = b
Output:
5:5:production rule <a> already exists
5:5:production rule <a> already exists
There was a problem hiding this comment.
Oh that makes sense. Those are good examples, thank you!
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to be embedded as a library, because it interrupts the caller. The previous patch removed usage of exit for every generators: katef#40 This one removes usage of exit for every parser. The parsing_error struct is introduced to list all the errors. Issue: - katef#38 - ArthurSonzogni/Diagon#19
ArthurSonzogni
force-pushed
the
task/no-exit-in-parser
branch
from
2bbd2a1 to
b1b825a
Compare
katef
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to
be embedded as a library, because it interrupts the caller.
The previous patch removed usage of exit for every generators:
#40
This one removes usage of exit for every parser. The parsing_error
struct is introduced to list all the errors.
Issue: