Some simplification to script number types #594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifying
OpcodeData<i32/i64/Kip10I64>
to useSizedEncodeInt
for serialization.Critical lines and explanation:
Here we limit any
push_item<i32>
to 4 bytes. This is fine since we nowhere use this method.Here we limit any
push_item<i64>
to 8 bytes. Explanation for safety is in the code.Here we limit any
pop_items<i32>
to 4 bytes, disallowing the use ofi32::MIN
. This is fine since in any place we usepop_items<i32>
we also return an error if the number is negative.