update: version & add: fast-flags #29
Conversation
src/main.rs
Outdated
| /// Select Sovereign | ||
| #[arg(short, long = "chain-mode")] | ||
| mode: Option<String>, | ||
| /// Select between Avail, Celestia, Ethereum, NoDA |
There was a problem hiding this comment.
let the comment be select da layer, otherwise you need to change on every new addition
There was a problem hiding this comment.
Yeah, but it should be exact string or we won't be able to parse the Enum out of it. Eth instead of Ethereum would fail.
There was a problem hiding this comment.
found a way to pass Enum itself, updated
src/main.rs
Outdated
| /// App chain name | ||
| #[arg(short, long = "chain-name")] | ||
| name: Option<String>, | ||
| /// Select Sovereign |
There was a problem hiding this comment.
let the comment be select DaMode
There was a problem hiding this comment.
Same as above, it should be exact string
src/utils/madara.rs
Outdated
| @@ -60,6 +60,8 @@ pub fn setup_and_run_madara(config: AppChainConfig) -> Result<(), MadaraError> { | |||
| &base_path, | |||
| ]; | |||
|
|
|||
| args.extend(flags.split(",").map(|flag| flag.trim()).filter(|flag| !flag.is_empty())); | |||
There was a problem hiding this comment.
is there no way I can do something like
madara run -- --port=9946
basically all args passed after -- go to Madara. this is pretty common in other CLI tools
src/cli/explorer.rs
Outdated
| Some(host_config), | ||
| ) | ||
| .await; | ||
| run_docker_image("anshalshukla/starkcompass:latest", CONTAINER_NAME, Some(env), Some(host_config)).await; |
There was a problem hiding this comment.
let's ask them to create a release? or let's push it on our ECR if you think that will take time
No description provided.