Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the attached binding deletion problem #6034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix the attached binding deletion problem #6034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/dependenciesdistributor/dependencies_distributor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,13 @@ func (d *DependenciesDistributor) createOrUpdateAttachedBinding(attachedBinding
bindingKey := client.ObjectKeyFromObject(attachedBinding)
err := d.Client.Get(context.TODO(), bindingKey, existBinding)
if err == nil {
// When a dependent resource is deleted, it's ResourceBinding deletion may be delayed, depending on the system load status.
// If it is recreated again, it's ResourceBinding may be updated instead of recreated because the previous ResourceBinding deletion has not yet completed.
// We return an error here to wait for it's ResourceBinding deletion to complete, this will ensure it's ResourceBinding is recreated correctly.
if !existBinding.DeletionTimestamp.IsZero() {
return fmt.Errorf("unable to update resourceBinding(%s) because it's being deleted", bindingKey)
}

// If the spec.Placement is nil, this means that existBinding is generated by the dependency mechanism.
// If the spec.Placement is not nil, then it must be generated by PropagationPolicy.
if existBinding.Spec.Placement == nil {
Expand Down