-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added 's' shorthand to operation-scope flags #5483
feat: Added 's' shorthand to operation-scope flags #5483
Conversation
Welcome @ahorine! It looks like this is your first PR to karmada-io/karmada 🎉 |
The operation-scope flag gets used a lot when examining resources on member clusters. The 's' shorthand was added to improve user QoL. Signed-off-by: ahorine <[email protected]>
80e0990
to
5d2cf3e
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5483 +/- ##
==========================================
- Coverage 31.71% 31.70% -0.01%
==========================================
Files 643 643
Lines 44444 44444
==========================================
- Hits 14094 14091 -3
- Misses 29321 29323 +2
- Partials 1029 1030 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ahorine Is |
@zhzhuang-zju Currently the That said, since |
Glad to hear that. The capability enhancements are ongoing, and you can track the new features of
Get it. Frequently using the full name of |
@ahorine Thank you for doing this and giving feedback, it means a lot to us. Usually, we would be cautious about introducing shorthand parameters as those might bring confusion and ambiguity. But as you mentioned, this parameter will be used frequently, so I think giving a shorthand parameter is reasonable. Given that this PR is unlikely to be backported, this change might be included in v1.12 instead of v1.11.x. Is that OK with you? By the way, are you using Karmada now? Just want you to know that we'd always love to establish connections with users to listen to voices, provide support, and so on. |
A v1.12 target is absolutely fine considering this is largely QoL more than anything else.
Yes, I am the lead for devops/cloudops/infra for the dev and test teams for the products we’re working on, and one of the current projects is supporting geo redundancy. I have 6+ environments between dev and test running Karmada currently, with some more planned. I’m already in the Slack channels, and I’m sure I’ll be getting involved a bit more going forward as the efforts I’m supporting start ramping up. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I updated the release notes a little bit, by the way.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The operation-scope flag gets used a lot when examining resources on member clusters. The 's' shorthand was added to improve user QoL.
Does this PR introduce a user-facing change?: