-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charts: add the missing dashboard configmap #124
Conversation
Signed-off-by: Xinzhao Xu <[email protected]>
/assign |
/test |
Is there anything we can do with it? /retest |
retest command seems not work. |
I found the solution, not sure why we haven't encountered this problem before, but the CI is happy now. |
Tracked by #125 |
I misunderstand the this only execute the when execute the command The better way to fix the problem is that changing the following two lines: dashboard/.github/workflows/ci.yml Lines 37 to 38 in 60a4bcb
to the following pnpm install --filter @karmada/dashboard
pnpm run dashboard:build the only difference is that it declared that pnpm should install dependencies for @karmada/dashboard explicitly. cc @iawia002 |
{{- end -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great ~
Signed-off-by: Xinzhao Xu <[email protected]>
Cool, it works. PTAL @warjiang |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* charts: add the missing dashboard configmap Signed-off-by: Xinzhao Xu <[email protected]> * ci: fix build-frontend Signed-off-by: Xinzhao Xu <[email protected]> --------- Signed-off-by: Xinzhao Xu <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix #120
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/cc @warjiang @RainbowMango