Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts: add the missing dashboard configmap #124

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

iawia002
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix #120

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

/cc @warjiang @RainbowMango

@karmada-bot karmada-bot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2024
@warjiang
Copy link
Contributor

/assign

@warjiang
Copy link
Contributor

warjiang commented Sep 12, 2024

/test

@RainbowMango
Copy link
Member

> @karmada/[email protected] build /home/runner/work/dashboard/dashboard/ui/apps/dashboard
> tsc && vite build

/home/runner/work/dashboard/dashboard/ui/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/native.js:59
		throw new Error(
		      ^

Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4[82](https://github.com/karmada-io/dashboard/actions/runs/10826402935/job/30037300368?pr=124#step:5:83)8). Please try `npm i` again after removing both package-lock.json and node_modules directory.

Is there anything we can do with it?

/retest
Give it another try

@warjiang
Copy link
Contributor

> @karmada/[email protected] build /home/runner/work/dashboard/dashboard/ui/apps/dashboard
> tsc && vite build

/home/runner/work/dashboard/dashboard/ui/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/native.js:59
		throw new Error(
		      ^

Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4[82](https://github.com/karmada-io/dashboard/actions/runs/10826402935/job/30037300368?pr=124#step:5:83)8). Please try `npm i` again after removing both package-lock.json and node_modules directory.

Is there anything we can do with it?

/retest Give it another try

retest command seems not work.
I'll check it the task(build-frontend) locally

@iawia002
Copy link
Member Author

I found the solution, not sure why we haven't encountered this problem before, but the CI is happy now.

@RainbowMango
Copy link
Member

retest command seems not work.

Tracked by #125

@warjiang
Copy link
Contributor

@rollup/rollup-linux-x64-gnu

I misunderstand the pnpm install -w,
image

this only execute the pnpm install command in the root dir(here is ui, so it only install dependencies according to ui/package.json),
image

when execute the command pnpm run dashboard:build, the dependencies for dashboard are not installed now, so the process of build failed. I think it's an exist problem, but it worked for the past months 🤔 .

The better way to fix the problem is that changing the following two lines:

pnpm install -w
pnpm run dashboard:build

to the following

pnpm install --filter @karmada/dashboard
pnpm run dashboard:build

the only difference is that it declared that pnpm should install dependencies for @karmada/dashboard explicitly. cc @iawia002

{{- end -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great ~

Signed-off-by: Xinzhao Xu <[email protected]>
@iawia002
Copy link
Member Author

pnpm install --filter @karmada/dashboard
pnpm run dashboard:build

Cool, it works. PTAL @warjiang

@RainbowMango RainbowMango added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 13, 2024
@warjiang
Copy link
Contributor

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@karmada-bot karmada-bot merged commit efa7448 into karmada-io:main Sep 13, 2024
6 checks passed
@iawia002 iawia002 deleted the chart branch September 13, 2024 02:40
chouchongYHMing pushed a commit to chouchongYHMing/dashboard that referenced this pull request Sep 25, 2024
* charts: add the missing dashboard configmap

Signed-off-by: Xinzhao Xu <[email protected]>

* ci: fix build-frontend

Signed-off-by: Xinzhao Xu <[email protected]>

---------

Signed-off-by: Xinzhao Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The overview page crashed: TypeError: i is not iterable
4 participants