Add Integration Tests for Kopia RepositoryServer based kando Blueprint for MySQL #2026

r4rajat · 2023-04-18T06:49:35Z

Change Overview

Add Integration Tests for Kopia RepositoryServer based kando blueprint for MySQL

Pull request type

Please check the type of change your PR introduces:

Issues

fixes #issue-number

Test Plan

💪 Manual
⚡ Unit test
💚 E2E

Manual Testing

1) Deploy Kanister

helm install kanister ./helm/kanister-operator \
--namespace kanister \
--set image.repository=r4rajat/controller \
--set image.tag=v69 \
--set repositoryServerControllerImage.registry=r4rajat \
--set repositoryServerControllerImage.name=repo-server-controller \
--set repositoryServerControllerImage.tag=v69 \
--set controller.parallelism=10 \
--create-namespace

2) Change target of integration-test in makefile

integration-test: build-dirs
	@$(MAKE) run CMD='-c "./build/integration-test.sh kopia"'

3) Install minio

make install-minio

4) Run Integration Tests

make integration-test

Signed-off-by: Rajat Gupta <[email protected]>

github-actions · 2023-04-18T06:49:54Z

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

Signed-off-by: Rajat Gupta <[email protected]>

pkg/app/kopia_repository_server_mysql.go

Signed-off-by: Rajat Gupta <[email protected]>

…pia-repo-server-functions # Conflicts: # pkg/kopia/command/storage/storage_args.go # pkg/secrets/repositoryserver/const.go # pkg/testing/integration_register.go

denisvmedia · 2023-09-13T08:00:27Z

pkg/app/kopia_repository_server_mysql.go

+}
+
+func (mdb *KopiaRepositoryServerMysqlDB) Chart() *helm.ChartInfo {
+	return &mdb.chart


Is retiring a pointer to the internal field desired? This might lead to external changes that could be potentially undesired here. WDYT?

Signed-off-by: Rajat Gupta <[email protected]>

kale-amruta

Added few comments

kale-amruta · 2023-09-15T06:38:52Z

pkg/testutil/kopia_testutil.go

+	// DefaultKopiaRepositoryServerAdminPassword is the default password for the kopia repository server admin user.
+	DefaultKopiaRepositoryServerAdminPassword = "admin1234"
+)
+


@r4rajat this file contains lot of redundant code that pkg/testutil/testutil.go has. Should we reuse the functions in that file wherever possible?

kale-amruta · 2023-09-15T06:59:45Z

pkg/testing/integration_test.go

+	s.kopiaRepositoryServer.repositoryServer.Spec.Server.TLSSecretRef = corev1.SecretReference{
+		Name:      tls.GetName(),
+		Namespace: tls.GetNamespace(),
+	}


Should we move creation of secrets to another function? We are currently using s3 as a profile, but we have to write integration tests for other profiles such as filestore as well. In that case if creation of secrets is made generic, that would be useful

github-actions · 2023-12-15T00:10:13Z

This PR is marked as stale due to inactivity. Add a new comment to reactivate it.

viveksinghggits · 2023-12-15T09:31:43Z

@r4rajat

github-actions · 2024-03-15T00:10:22Z

This PR is marked as stale due to inactivity. Add a new comment to reactivate it.

r4rajat and others added 11 commits March 31, 2023 20:18

Add Kopia Repository Server based Blueprint for mysql

706f4cd

Signed-off-by: Rajat Gupta <[email protected]>

Add Newline

21cc806

Signed-off-by: Rajat Gupta <[email protected]>

Add README.md

bf5db94

Signed-off-by: Rajat Gupta <[email protected]>

Merge branch 'master' into mysql-blueprint-kopia-repository-server

e349d85

Update README.md

79c37ab

Signed-off-by: Rajat Gupta <[email protected]>

Add mysql image build in .goreleaser.yml

15e4a11

Signed-off-by: Rajat Gupta <[email protected]>

Update README.md

2b0e820

Signed-off-by: Rajat Gupta <[email protected]>

Merge branch 'master' into mysql-blueprint-kopia-repository-server

c11d88f

Merge branch 'master' into mysql-blueprint-kopia-repository-server

6a1e1d5

Make replicaCount dynamic

61e1a5a

Signed-off-by: Rajat Gupta <[email protected]>

Add Integration Tests for Kopia RepositoryServer

f1df2f6

r4rajat and others added 5 commits April 18, 2023 12:21

Add newline

76c9839

Merge branch 'master' into integration-test-kopia-repo-server-functions

ec7fa2d

Fix Lint Error

dcde3ce

Signed-off-by: Rajat Gupta <[email protected]>

Merge branch 'master' into mysql-blueprint-kopia-repository-server

7b38835

Update Docs

1d17619

Signed-off-by: Rajat Gupta <[email protected]>

r4rajat requested review from pavannd1, PrasadG193 and viveksinghggits April 21, 2023 07:06

r4rajat and others added 2 commits April 21, 2023 13:07

Update dependencies

2c0cba8

Signed-off-by: Rajat Gupta <[email protected]>

Merge branch 'master' into integration-test-kopia-repo-server-functions

d5a4327

r4rajat changed the base branch from master to mysql-blueprint-kopia-repository-server April 21, 2023 07:39

r4rajat changed the base branch from mysql-blueprint-kopia-repository-server to master April 21, 2023 07:39

r4rajat and others added 3 commits April 21, 2023 13:09

Merge branch 'master' into mysql-blueprint-kopia-repository-server

cbc9233

Fix Lint

5a24bc3

Signed-off-by: Rajat Gupta <[email protected]>

Fix Lint Error

46a11d3

Signed-off-by: Rajat Gupta <[email protected]>

denisvmedia reviewed Apr 21, 2023

View reviewed changes

pkg/app/kopia_repository_server_mysql.go Outdated Show resolved Hide resolved

r4rajat requested a review from denisvmedia April 24, 2023 07:05

Update kopia_repository_server_mysql.go

cbac80e

Signed-off-by: Rajat Gupta <[email protected]>

r4rajat changed the title ~~Add Integration Tests for Kopia RepositoryServer based functions~~ Add Integration Tests for Kopia RepositoryServer based kando blueprint for MySQL Jun 6, 2023

Merge branch 'master' into integration-test-kopia-repo-server-functions

6449fdc

r4rajat changed the title ~~Add Integration Tests for Kopia RepositoryServer based kando blueprint for MySQL~~ Add Integration Tests for Kopia RepositoryServer based kando Blueprint for MySQL Jun 6, 2023

r4rajat and others added 6 commits June 7, 2023 11:04

Update integration_test.go

fd7a49e

Signed-off-by: Rajat Gupta <[email protected]>

Update integration_test.go

a97f266

Signed-off-by: Rajat Gupta <[email protected]>

Fix Lint Issues

a21b6b8

Signed-off-by: Rajat Gupta <[email protected]>

Merge branch 'master' into integration-test-kopia-repo-server-functions

306d2a1

Merge branch 'master' into integration-test-kopia-repo-server-functions

409ef76

Merge branch 'master' into integration-test-kopia-repo-server-functions

82d14e8

pavannd1 requested review from viveksinghggits and removed request for viveksinghggits and PrasadG193 June 13, 2023 06:57

r4rajat mentioned this pull request Jul 6, 2023

Add Type S3Compliant to Kopia Repository Storage Args #2159

Merged

10 tasks

r4rajat and others added 2 commits August 8, 2023 15:18

Merge remote-tracking branch 'origin/master' into integration-test-ko…

27796c4

…pia-repo-server-functions # Conflicts: # pkg/kopia/command/storage/storage_args.go # pkg/secrets/repositoryserver/const.go # pkg/testing/integration_register.go

Merge branch 'master' into integration-test-kopia-repo-server-functions

3792e0e

denisvmedia reviewed Sep 13, 2023

View reviewed changes

r4rajat and others added 4 commits September 13, 2023 18:34

Fix Lint Issues: Remove Reductant Code

426875e

Signed-off-by: Rajat Gupta <[email protected]>

Refactored Imports

9d709d7

Signed-off-by: Rajat Gupta <[email protected]>

Merge branch 'master' into integration-test-kopia-repo-server-functions

7d1afe1

Merge branch 'master' into integration-test-kopia-repo-server-functions

b71d133

kale-amruta reviewed Sep 15, 2023

View reviewed changes

github-actions bot added the stale label Dec 15, 2023

github-actions bot removed the stale label Dec 16, 2023

github-actions bot added the stale label Mar 15, 2024

pavannd1 added frozen and removed stale labels Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Integration Tests for Kopia RepositoryServer based kando Blueprint for MySQL #2026

Add Integration Tests for Kopia RepositoryServer based kando Blueprint for MySQL #2026

r4rajat commented Apr 18, 2023 •

edited

Loading

github-actions bot commented Apr 18, 2023

denisvmedia Sep 13, 2023

kale-amruta left a comment

kale-amruta Sep 15, 2023

kale-amruta Sep 15, 2023

github-actions bot commented Dec 15, 2023

viveksinghggits commented Dec 15, 2023

github-actions bot commented Mar 15, 2024

Add Integration Tests for Kopia RepositoryServer based kando Blueprint for MySQL #2026

Are you sure you want to change the base?

Add Integration Tests for Kopia RepositoryServer based kando Blueprint for MySQL #2026

Conversation

r4rajat commented Apr 18, 2023 • edited Loading

Change Overview

Pull request type

Issues

Test Plan

Manual Testing

1) Deploy Kanister

2) Change target of integration-test in makefile

3) Install minio

4) Run Integration Tests

github-actions bot commented Apr 18, 2023

denisvmedia Sep 13, 2023

Choose a reason for hiding this comment

kale-amruta left a comment

Choose a reason for hiding this comment

kale-amruta Sep 15, 2023

Choose a reason for hiding this comment

kale-amruta Sep 15, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 15, 2023

viveksinghggits commented Dec 15, 2023

github-actions bot commented Mar 15, 2024

r4rajat commented Apr 18, 2023 •

edited

Loading