NASM: Fix bug in str when appending empty arrays #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `slurp` function can produce strings which end with an empty Array, if the input file is a multiple of the Array size. When appending such a string, `string_append_string` would keep reading past the end of the string, and continue until it ran out of memory. This fix adds a check for empty Array.
|
Thanks @bendudson. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
slurpfunction can produce strings which end with an empty Array, if the input file is a multiple of the Array size. When appending such a string,string_append_stringwould keep reading past the end of the string, and continue until it ran out of memory. This fix adds a check for empty Array.Partly fixes issue #418