PLAT-24975: Validate user when editing Annotation Cue Points on entries #12964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbar0kal
approved these changes
Nov 11, 2024
muli
reviewed
Nov 11, 2024
There was a problem hiding this comment.
@inbal-ben-david, @drorsou - please see my comment on this one.
| } | ||
| protected function validateEntryEntitlement(entry $dbEntry, $tags) | ||
| { | ||
| if (!kEntitlementUtils::isEntryEntitled($dbEntry) && str_contains($tags, 'hotspots')) |
There was a problem hiding this comment.
If I have a cue-point with the following tags:
coolhotspotstag2tag3
which translates into coolhotspots,tag2,tag3 in the DB (and in the API entry object) - this restriction will apply there, which is unexpected.
I think that you should do something like
$tags = explode(',', $tags);
if (in_array('hotspots', $tags) && !kEntitlementUtils::isEntryEntitled($dbEntry)) {
// throw error
}Also notice the order of the conditions - isEntryEntitled will not execute if hotspots isn't one of the tags, which might be performance improvement.
There was a problem hiding this comment.
Opened a new PR #12969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.