plat 24912:Add support in V2 to V7 redirect #12849
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| <?php | ||
|
|
||
| class v2Tov7Utils | ||
| { | ||
| const V2TOV7_PARAM_NAME = 'v2tov7'; | ||
| const FLASHVARS_PARAM_NAME = 'flashvars'; | ||
| const SHOULD_TRANSLATE_PLUGINS = self::V2TOV7_PARAM_NAME ."translate"; | ||
|
|
||
| static private function getV7PluginInfo($v2PluginName): array | ||
| { | ||
| KalturaLog::log("Searching for " . $v2PluginName . " " . strlen($v2PluginName)); | ||
|
There was a problem hiding this comment. why do you need to print strlen here? There was a problem hiding this comment. removed entire print message - needed only for debug |
||
| $translation = self::v2toV7PluginMap(); | ||
|
There was a problem hiding this comment. Why not simply save the map as a static member of the class instead of doing a function call here? If this could change you can even move it toa config (ini) file and load it using kConf to be able to change it without the need of pushing code changes for it. |
||
| if(isset($translation[$v2PluginName])) | ||
| { | ||
| $v7PluginInfo = $translation[$v2PluginName]; | ||
| KalturaLog::log("Found " . print_r($v7PluginInfo, true)); | ||
| return $v7PluginInfo; | ||
| } | ||
| else | ||
| { | ||
| throw new Exception ($v2PluginName); | ||
| } | ||
| } | ||
|
|
||
| static function addV2toV7plugins($flashvars, &$bundleConfig, &$playerConfig) | ||
| { | ||
| if(!$flashvars) | ||
| { | ||
| return; | ||
| } | ||
| $unHandledPlugins = array(); | ||
|
|
||
| //Merge v7 config | ||
| foreach ($flashvars as $key => $value) | ||
| { | ||
| if(self::isVarPlugin($key)) | ||
| { | ||
| //get plugin name | ||
| KalturaLog::log("V2 to V7 adding plugin: " . $key. " value:" . $value); | ||
| if ($value) { | ||
| if (!$bundleConfig) { | ||
| $bundleConfig = []; | ||
| } | ||
| $key = trim(trim($key, '"'), "'"); | ||
| $v2PluginName = explode(".", $key); | ||
| try | ||
| { | ||
| $v7PluginName = self::getV7PluginInfo($v2PluginName[0]); | ||
| $bundleConfig = array_merge($bundleConfig, [$v7PluginName[0] => "{latest}"]); | ||
| $v7PluginConfig = $v7PluginName[1]; | ||
| if (!isset($playerConfig->plugins)) { | ||
| $playerConfig->plugins = new stdClass(); | ||
| } | ||
| if (!isset($playerConfig->plugins->$v7PluginConfig)) { | ||
| $playerConfig->plugins->$v7PluginConfig = new stdClass(); | ||
| } | ||
| } | ||
| catch (Exception $e){ | ||
| $unHandledPlugins[] = $e->getMessage(); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| if(sizeof($unHandledPlugins)) | ||
| { | ||
| throw new Exception ("Unhandled plugins: " . implode(", ", $unHandledPlugins)); | ||
| } | ||
| } | ||
|
|
||
| static function addV2toV7config($flashvars, $uiconfId) | ||
| { | ||
| $config = []; | ||
| //Merge v7 config | ||
|
|
||
| if($flashvars) | ||
| { foreach ($flashvars as $key => $value) { | ||
| $key = trim(trim($key, '"'), "'"); | ||
| $config[$key] = json_decode($value); | ||
| } | ||
| } | ||
| $config["uiconf_id"] = $uiconfId; | ||
| return $config; | ||
| } | ||
|
|
||
| private static function isVarPlugin($varKeyName) | ||
| { | ||
| return str_contains($varKeyName, ".plugin"); | ||
| } | ||
|
|
||
| private static function v2toV7PluginMap() | ||
| { | ||
| return | ||
| ["info" => ["playkitscreen", "playkit-js-info"], | ||
| "quiz" => ["playkit-ivq", "ivq"], | ||
| "moderation" => ["playkit-moderation", "playkit-js-moderation"], | ||
| "playlistAPI" => ["playkit-playlist", "playlist"], | ||
| "liveStatus" => ["playkit-kaltura-live","kaltura-live"], | ||
| "related" => ["playkit-related", "related"], | ||
| "dualScreen" => ["playkit-dual-screen", "dualscreen"], | ||
| "video360" => ["playkit-vr" ,"vr"], | ||
| "raptMedia" => ["rapt", "rapt"], | ||
| "transcript" => ["playkit-transcript", "playkit-js-transcript"], | ||
| "qna" => ["playkit-qna", "qna"], | ||
| "bumper" => [ "playkit-bumper" , "bumper" ], | ||
| "infoScreen" => ["playkit-info", "playkit-js-info"]]; | ||
| } | ||
|
|
||
| public static function getBundledFacade() | ||
| { | ||
| //build key based on version | ||
| $facadeVersion = kConf::getArrayValue('v2tov7FacadeVersion','playkit-js'); | ||
|
There was a problem hiding this comment. Where is the config for v2tov7FacadeVersion do you have another PR for it? There was a problem hiding this comment. This needs to go to local.ini |
||
| $facadeVersion .= "/v2tov7Facade.js"; | ||
|
|
||
| //try get value from local memcache | ||
| $cacheStore = kCacheManager::getSingleLayerCache(kCacheManager::CACHE_TYPE_PLAYKIT_JS); | ||
| $bundledFacade = $cacheStore->get($facadeVersion); | ||
| if(strlen($bundledFacade)) | ||
| { | ||
| return $bundledFacade; | ||
| } | ||
|
|
||
| //if not local - get it from remote location | ||
| $remoteUrl = kConf::getArrayValue('v2tov7FacadeRemoteUrl','playkit-js'); | ||
|
There was a problem hiding this comment. Where is the config for v2tov7FacadeRemoteUrl do you have another PR for it? |
||
| $remoteUrl .= '/' . $facadeVersion; | ||
|
|
||
| $curlWrapper = new KCurlWrapper(); | ||
|
|
||
| $content = $curlWrapper->exec($remoteUrl,null, null, true); | ||
| if(KCurlHeaderResponse::isError($curlWrapper->getHttpCode())) | ||
| { | ||
| throw new Exception ('Cannot find V2 to V7 facade in the following URL: ' . $remoteUrl . "Error code:" . $curlWrapper->getHttpCode()); | ||
| } | ||
|
|
||
| //store in local cache for next time | ||
| $cacheStore->set($facadeVersion,$content); | ||
| return $content; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like all these v2tov7. why not have something more intuitive v7CompatibleId or something similar