Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace get_class() call, deprecated since PHP 8.3 #514

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

alexandergotts
Copy link
Contributor

No description provided.

@alexandergotts alexandergotts changed the title Update Plugin_controller.php php 8.3 fix __CLASS__ Feb 16, 2024
@alexandergotts alexandergotts changed the base branch from devel to master February 16, 2024 17:19
@tenzap
Copy link
Collaborator

tenzap commented Feb 17, 2024

When merging we would be careful to set the commit message. Something like. Replace get_class() call, deprecated since PHP 8.3

@alexandergotts alexandergotts changed the title php 8.3 fix __CLASS__ Replace get_class() call, deprecated since PHP 8.3 Feb 17, 2024
@alexandergotts
Copy link
Contributor Author

fix

@tenzap
Copy link
Collaborator

tenzap commented Feb 17, 2024

You actually changed the title of the pr, not of the commit. Anyway, my message was intended to the person who will merge the pr.

@tenzap tenzap mentioned this pull request Feb 17, 2024
@tenzap tenzap merged commit 21fccac into kalkun-sms:master Feb 17, 2024
3 checks passed
@tenzap
Copy link
Collaborator

tenzap commented Feb 18, 2024

@alexandergotts, next time, please file the PR against "devel" branch, not master. I wasn't careful enough this time.

@alexandergotts alexandergotts deleted the php8.3_fix branch February 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants