-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: height in grid #1155
base: dev
Are you sure you want to change the base?
fix: height in grid #1155
Conversation
Should we then merge this after #1139 ?
What do you mean by this? Are sections still beta? |
Yes, still experimental... But many beginners use it and some of them seems like unaware about the old-style working way... |
Recently got home, have not seen this PR yet. |
Based on my estimation of users using sections: I would say that my PR may come first ))))) |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I checked this out and, yes, it fixes the height of the card to the required grid rows... But: The graph remains very miniature and squashed to the bottom: That is not what I would expect. I would expect the graph to fill the space defined by the number of rows... I created #1199, which has my current working state based on the original sections PR. But I stripped out all the advanced features for the time being. Could you check this out and let me know, if this feels more intuitive to you, too? (It does for me.) |
Before:
After:
Probably may be useful in case of using a new experimental "sections" views (honestly, do not care about this still beta feature).