Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auroraboot #1138

Closed
wants to merge 3 commits into from
Closed

Add auroraboot #1138

wants to merge 3 commits into from

Conversation

jimmykarily
Copy link
Contributor

Part of: kairos-io/kairos#1633

(to have it as an installation option in cases where we used to install enki like this)

@jimmykarily jimmykarily marked this pull request as ready for review November 13, 2024 06:39
@jimmykarily jimmykarily self-assigned this Nov 13, 2024
@jimmykarily jimmykarily requested a review from a team November 13, 2024 06:41
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
@@ -2,7 +2,7 @@ packages:
- name: toolchain-go
category: development
variant: "alpine"
version: "1.23.2"
version: "1.23.3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the auroraboot build was failing because it required this bump (afaict)

Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this to be honest. Providing a docker file that auto builds al releases automatically like we did with enki seems like a saner approach and the pipeline already supports that. And os builder tools is provided as a docker file which makes it easy to bring binaries from other parts as we did with enki

This creates yet another package and while it may be helpful as we can install it directly in the os builder tools, isn't the point to make auroraboot the main image and install the tools onto that image instead? So all this scripts on os builder tools would go into aurora instead?

Maybe I understood it wrongly?

@jimmykarily
Copy link
Contributor Author

I'm not sure about this to be honest. Providing a docker file that auto builds al releases automatically like we did with enki seems like a saner approach and the pipeline already supports that. And os builder tools is provided as a docker file which makes it easy to bring binaries from other parts as we did with enki

This creates yet another package and while it may be helpful as we can install it directly in the os builder tools, isn't the point to make auroraboot the main image and install the tools onto that image instead? So all this scripts on os builder tools would go into aurora instead?

Maybe I understood it wrongly?

No you got it right. I wasn't sure about this one either. I just thought it will be good to have another way to get just the auroraboot binary since the image we will be building from now on, won't be a small one with just auroraboot but the merge of the osbuilder-tools one with the auroraboot image.
But we do provide github artifacts so if someone wants just the binary, they can get it from there.

I'll close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants