Add test for custom partioning #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmykarily
force-pushed
the
2281-custom-partioning
branch
3 times, most recently
from
c8ef32a
to
fb9cc4c
Compare
jimmykarily
force-pushed
the
2281-custom-partioning
branch
from
1b2c7a7
to
7f094ea
Compare
jimmykarily
force-pushed
the
2281-custom-partioning
branch
from
b8993c0
to
2a1e026
Compare
jimmykarily
commented
Apr 10, 2024
|
The |
jimmykarily
force-pushed
the
2281-custom-partioning
branch
from
6d610a1
to
e88c86a
Compare
jimmykarily
force-pushed
the
2281-custom-partioning
branch
from
e88c86a
to
98ca4cb
Compare
Itxaka
reviewed
Apr 12, 2024
| Expect(err).ToNot(HaveOccurred()) | ||
| fmt.Printf("State dir: %s\n", stateDir) | ||
|
|
||
| opts := defaultVMOptsNoDrives(stateDir) |
| flavor: | ||
| - "ubuntu" | ||
| flavorRelease: | ||
| - "23.10" |
There was a problem hiding this comment.
if this gets merged after #2447, we should add 24.04 here, or if it's the other way around then we should add it in the other PR, putting a comment there too
mauromorales
approved these changes
Apr 12, 2024
not currently passing because the fix is not there (TDD) Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Locally I had a forgotten "FIRMWARE" env variable set (from previous runs) and that make my tests pass with efi partitions. In CI it boot in legacy bios mode. Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
2281-custom-partioning
branch
from
98ca4cb
to
05e6647
Compare
mauromorales
pushed a commit
that referenced
this pull request
May 2, 2024
* Add test for custom partioning not currently passing because the fix is not there (TDD) Signed-off-by: Dimitris Karakasilis <[email protected]> * Add sanity check and fix config Signed-off-by: Dimitris Karakasilis <[email protected]> * Remove "replace" for peg in go.mod (now merged) Signed-off-by: Dimitris Karakasilis <[email protected]> * [TMP] Run tests using a branch Signed-off-by: Dimitris Karakasilis <[email protected]> * Add custom partitioning test in the pipelines Signed-off-by: Dimitris Karakasilis <[email protected]> * Use core artifact Signed-off-by: Dimitris Karakasilis <[email protected]> * Change flavor to one that we actually build Signed-off-by: Dimitris Karakasilis <[email protected]> * Fix test Signed-off-by: Dimitris Karakasilis <[email protected]> * Bump kairos-agent through framework and remove tmp hack Signed-off-by: Dimitris Karakasilis <[email protected]> * Apply suggestions from code review Signed-off-by: Dimitris Karakasilis <[email protected]> * Use setup for legacy bios Locally I had a forgotten "FIRMWARE" env variable set (from previous runs) and that make my tests pass with efi partitions. In CI it boot in legacy bios mode. Signed-off-by: Dimitris Karakasilis <[email protected]> --------- Signed-off-by: Dimitris Karakasilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not currently passing because the fix is not there (TDD)
Part of #2281
the fix will happen here: kairos-io/kairos-agent#235
Depends on: spectrocloud/peg#23
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #