Skip to content
This repository has been archived by the owner on Nov 12, 2024. It is now read-only.

Refactor enki build-uki command #224

Closed
wants to merge 2 commits into from

Commits on Nov 1, 2024

  1. Refactor enki build-uki command

    so that it can be used as a library from Auroraboot
    as part of kairos-io/kairos#1633
    
    The following anti-patterns make it very hard to re-use the enki
    functions:
    
    - viper is used as a global store, randomly accessing everything from anywhere
    - we pass around too many "configs": the BuildConfig, the embedded
      kairos-agent config, the BuildUKIAction (which is essentially yet another config),
    
    It's nearly impossible to construct the proper input for any function
    because we don't know what part of the configs available, is actually needed
    and used.
    
    This is a first refactoring that should at least let the caller use the
    BuildUKIAction without needing to populate a global "viper" object.
    
    Signed-off-by: Dimitris Karakasilis <[email protected]>
    jimmykarily committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    950d879 View commit details
    Browse the repository at this point in the history
  2. WIP Try to improve things (looks desperate :( )

    Signed-off-by: Dimitris Karakasilis <[email protected]>
    jimmykarily committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    144fff3 View commit details
    Browse the repository at this point in the history