Don't put artifacts in a build/ subdirectory
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmykarily
force-pushed
the
no-subdirectory-for-artifacts
branch
2 times, most recently
from
dd0cb1c
to
3b796a5
Compare
When the user says "--output mydir" they really expect the artifacts to be in `mydir`, not in `mydir/build`. See also: - kairos-io/osbuilder#192 (comment) - kairos-io/kairos-docs#311 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
no-subdirectory-for-artifacts
branch
from
3b796a5
to
2e639b8
Compare
Itxaka
reviewed
Nov 15, 2024
Itxaka
reviewed
Nov 15, 2024
Itxaka
approved these changes
Nov 15, 2024
jimmykarily
added a commit
to kairos-io/osbuilder
that referenced
this pull request
Nov 15, 2024
because it has been fixed here: kairos-io/AuroraBoot#115 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
added a commit
to kairos-io/osbuilder
that referenced
this pull request
Nov 15, 2024
* Remove references to osbuilder-tools image because it has been merged with auroraboot here: kairos-io/AuroraBoot#110 as part of kairos-io/kairos#1633 Signed-off-by: Dimitris Karakasilis <[email protected]> * WIP Signed-off-by: Dimitris Karakasilis <[email protected]> * Fix test command Signed-off-by: Dimitris Karakasilis <[email protected]> * go mod tidy Signed-off-by: Dimitris Karakasilis <[email protected]> * Bump linting action Signed-off-by: Dimitris Karakasilis <[email protected]> * Don't look for artifacts in build/ subdir because it has been fixed here: kairos-io/AuroraBoot#115 Signed-off-by: Dimitris Karakasilis <[email protected]> --------- Signed-off-by: Dimitris Karakasilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user says "--output mydir" they really expect the artifacts to be in
mydir, not inmydir/build.See also: