1633 no more enki dependencies #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used this branch: https://github.com/kairos-io/enki/pull/219/files so we can also bundle some deps Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
changed the title
jimmykarily
commented
Nov 12, 2024
| } | ||
|
|
||
| // BuildConfig represents the config we need for building isos, raw images, artifacts | ||
| type BuildConfig struct { |
There was a problem hiding this comment.
I'm reluctant to create a "config" package in auroraboot because I'm hoping we can get rid of all these "config" structs that behave like "store everything" objects. That's why I put all the structs next to where they are used, to make it simpler to refactor.
because the first mount might not be fully complete when we try to mount the thing inside it Signed-off-by: Dimitris Karakasilis <[email protected]>
Itxaka
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of kairos-io/kairos#1633
also porting this https://github.com/kairos-io/enki/pull/219/files