-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update memo format and make memo updatable #2
Update memo format and make memo updatable #2
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Hi @yoomee1313 can you sign the CLA |
I have read the CLA Document and I hereby sign the CLA |
@Sotatek-TinnNguyen I have signed the CLA and CLA works well. However, Check Links task fails.. Do you know why it fails?
|
@yoomee1313 I think this issue in here: Maybe we need to use the circleCI |
@Sotatek-TinnNguyen I(yoomee1313) created this PR(#6) and check-link github action is passed. |
the github action works fine with PR inside repo but can not work with PR from fork repo @yoomee1313 |
I'll merge this PR since check I have checked that check links actually works. |
This PR updates memo format of the kip-103 and kip-160 and adds enabling editing memo section in kip-160.
pendingMemo
stroage andsetPendingMemo
method. finalizeContract doesn't accept memo string anymore.