Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memo format and make memo updatable #2

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

yoomee1313
Copy link
Contributor

This PR updates memo format of the kip-103 and kip-160 and adds enabling editing memo section in kip-160.

  • kip-103: revise memo format of a Info-log to match with the contract memo format
  • kip-160: add new memo format. The reason of introducing new memo format is to get the additional balance data to calculate burnt amount directly.
  • kip-160: added pendingMemo stroage and setPendingMemo method. finalizeContract doesn't accept memo string anymore.

Copy link

github-actions bot commented Jun 25, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Sotatek-TinnNguyen
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@Sotatek-TinnNguyen
Copy link
Contributor

Hi @yoomee1313 can you sign the CLA

@yoomee1313
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@yoomee1313
Copy link
Contributor Author

@Sotatek-TinnNguyen I have signed the CLA and CLA works well. However, Check Links task fails.. Do you know why it fails?

Run peter-evans/create-issue-from-file@v4
Error: Resource not accessible by integration

@Sotatek-TinnNguyen
Copy link
Contributor

@yoomee1313 I think this issue in here: Maybe we need to use the circleCI

@yoomee1313
Copy link
Contributor Author

@Sotatek-TinnNguyen I(yoomee1313) created this PR(#6) and check-link github action is passed.
I think it's related to this setting: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks#about-workflow-runs-from-public-forks
Can the change of this setting solve the problem..??

@Sotatek-TinnNguyen
Copy link
Contributor

the github action works fine with PR inside repo but can not work with PR from fork repo @yoomee1313

@yoomee1313
Copy link
Contributor Author

I'll merge this PR since check I have checked that check links actually works.

@yoomee1313 yoomee1313 merged commit cb13759 into kaiachain:main Jun 28, 2024
1 of 2 checks passed
@yoomee1313 yoomee1313 deleted the update-memo-format-rebalance branch June 28, 2024 07:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants