-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add Shanghai tests by ethereum/execution-spec-tests
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Main] release/v1.0.1 QA Sign-off
[Main] release/v1.0.2 QA Sign-off
[Main] release/v1.0.3 QA Sign-off
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
ulbqb
force-pushed
the
eip-7702-exec-tests
branch
from
November 12, 2024 14:29
002866f
to
e62559e
Compare
ulbqb
changed the title
test: Add tests using ethereum/execution-spec-tests
test: Add tests by Nov 12, 2024
ethereum/execution-spec-tests
Update
|
hyunsooda
reviewed
Nov 18, 2024
Makefile
Outdated
@@ -28,10 +28,12 @@ abigen: | |||
@echo "Run \"$(BIN)/abigen\" to launch abigen." | |||
|
|||
test: | |||
$(GORUN) build/ci.go test | |||
$(GORUN) build/ci.go test -skip ^TestExecutionSpecState$$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blukat29 t.Parallel()
seems not much effective and shows no difference in my local. What do you think?
hyunsooda
reviewed
Nov 20, 2024
blukat29
approved these changes
Nov 25, 2024
hyunsooda
approved these changes
Nov 25, 2024
ian0371
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds tests by
ethereum/execution-spec-tests
. Currently, this supports testing only Shanghai EIPs against each forks (only Cancun and Prague). I'm going to add tests for other forks in other PRs.Simulating Ethereum behavior is needed because of the difference of spec between Kaia and Ethereum to use
ethereum/execution-spec-tests
as is. This simulate following behavior:Main code modifications:
Remarks:
related: #152
Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)