Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix miner errors in pact4->5 transition #2127

Closed
wants to merge 1 commit into from
Closed

Fix miner errors in pact4->5 transition #2127

wants to merge 1 commit into from
+2 −2

Conversation

edmundnoble
Copy link
Contributor

Change-Id: Id0000000457a9ac3d35b2a3b5376bfcb7554f51b

@edmundnoble
Fix miner errors in pact4->5 transition
259aa86 
Change-Id: Id0000000457a9ac3d35b2a3b5376bfcb7554f51b
@edmundnoble edmundnoble requested a review from chessai January 27, 2025 20:17
@edmundnoble edmundnoble marked this pull request as ready for review January 27, 2025 20:17
@edmundnoble edmundnoble marked this pull request as draft January 27, 2025 21:16
chessai
chessai requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@chessai chessai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is wrong, the respective returns should be bottom I thought?

@edmundnoble
Copy link
Contributor Author

Yes you have a point. I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chessai chessai chessai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundnoble @chessai