Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/Dynamic-table-comment-on-syntax #1

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

patkearns10
Copy link

@patkearns10 patkearns10 commented Sep 27, 2023

resolves dbt-labs#769
docs N/A

Problem

As discussed in comments here, the actual syntax should be alter table... not alter dynamic table...

error:
Screenshot 2023-09-27 at 2 01 46 PM

Solution

pass:
Screenshot 2023-09-27 at 2 01 57 PM

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • x] This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@kaarthik108 kaarthik108 self-requested a review September 27, 2023 22:04
Copy link
Owner

@kaarthik108 kaarthik108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @patkearns10

@kaarthik108 kaarthik108 merged commit 3fa7547 into kaarthik108:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-885] [Bug] Dynamic table alter syntax and comment syntax is wrong
2 participants