-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump spegel to v0.0.30 #11634
base: master
Are you sure you want to change the base?
Bump spegel to v0.0.30 #11634
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11634 +/- ##
==========================================
- Coverage 50.02% 47.63% -2.39%
==========================================
Files 185 185
Lines 19265 19341 +76
==========================================
- Hits 9637 9214 -423
- Misses 8236 8795 +559
+ Partials 1392 1332 -60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/trivy |
|
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
@@ -232,29 +230,52 @@ func (c *Config) Start(ctx context.Context, nodeConfig *config.Node) error { | |||
return err | |||
} | |||
mRouter.PathPrefix("/v2").Handler(regSvr.Handler) | |||
mRouter.PathPrefix("/v1-" + version.Program + "/p2p").Handler(c.peerInfo()) | |||
mRouter.PathPrefix("/v1-{program}/p2p").Handler(c.peerInfo()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this program value inject internally in Spegel now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just our route to the handler that returns the address list that is used by our custom agent bootstrapper. I missed this one when switching to {program}
in the prefix for other routes in #11471
Proposed Changes
With this change, all nodes now register their peer address in an annotation instead of only server nodes - and new nodes will be seeded with the complete list of cluster members instead of just a single random server node.
bootstrapper.Run()
to block until the context is done, as the libp2p host will now be closed as soon as that function returns: Fix p2p router close panic and add tests spegel-org/spegel#703 (comment)Types of Changes
version bump
Verification
Check version in go.mod
Testing
yes
Linked Issues
User-Facing Change
Further Comments