Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump spegel to v0.0.30 #11634

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump spegel to v0.0.30 #11634

wants to merge 2 commits into from

Conversation

brandond
Copy link
Member

@brandond brandond commented Jan 22, 2025

Proposed Changes

Types of Changes

version bump

Verification

Check version in go.mod

Testing

yes

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner January 22, 2025 01:52
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 11.44578% with 147 lines in your changes missing coverage. Please review.

Project coverage is 47.63%. Comparing base (3198b32) to head (7f9b61c).

Files with missing lines Patch % Lines
pkg/spegel/bootstrap.go 1.03% 96 Missing ⚠️
pkg/spegel/spegel.go 0.00% 36 Missing ⚠️
pkg/clientaccess/token.go 54.54% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11634      +/-   ##
==========================================
- Coverage   50.02%   47.63%   -2.39%     
==========================================
  Files         185      185              
  Lines       19265    19341      +76     
==========================================
- Hits         9637     9214     -423     
- Misses       8236     8795     +559     
+ Partials     1392     1332      -60     
Flag Coverage Δ
e2etests 40.44% <9.03%> (-3.86%) ⬇️
inttests 35.03% <11.44%> (-0.17%) ⬇️
unittests 16.98% <3.01%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwayne18
Copy link
Member

/trivy

Copy link
Contributor


For OSS Maintainers: VEX Notice
--------------------------------
If you're an OSS maintainer and Trivy has detected vulnerabilities in your project that you believe are not actually exploitable, consider issuing a VEX (Vulnerability Exploitability eXchange) statement.
VEX allows you to communicate the actual status of vulnerabilities in your project, improving security transparency and reducing false positives for your users.
Learn more and start using VEX: https://aquasecurity.github.io/trivy/v0.57/docs/supply-chain/vex/repo#publishing-vex-documents

To disable this notice, set the TRIVY_DISABLE_VEX_NOTICE environment variable.


bin/containerd-shim-runc-v2 (gobinary)
======================================
Total: 0 (HIGH: 0, CRITICAL: 0)


Suppressed Vulnerabilities (Total: 1)
=====================================
┌──────────────────┬────────────────┬──────────┬──────────────┬─────────────────────────────┬──────────────────────┐
│     Library      │ Vulnerability  │ Severity │    Status    │          Statement          │        Source        │
├──────────────────┼────────────────┼──────────┼──────────────┼─────────────────────────────┼──────────────────────┤
│ golang.org/x/net │ CVE-2024-45338 │ HIGH     │ not_affected │ vulnerable_code_not_present │ rancher.openvex.json │
└──────────────────┴────────────────┴──────────┴──────────────┴─────────────────────────────┴──────────────────────┘

bin/k3s (gobinary)
==================
Total: 0 (HIGH: 0, CRITICAL: 0)


Suppressed Vulnerabilities (Total: 2)
=====================================
┌─────────────────────┬────────────────┬──────────┬──────────────┬─────────────────────────────────────┬──────────────────────┐
│       Library       │ Vulnerability  │ Severity │    Status    │              Statement              │        Source        │
├─────────────────────┼────────────────┼──────────┼──────────────┼─────────────────────────────────────┼──────────────────────┤
│ golang.org/x/crypto │ CVE-2024-45337 │ CRITICAL │ not_affected │ vulnerable_code_not_present         │ rancher.openvex.json │
├─────────────────────┼────────────────┼──────────┤              ├─────────────────────────────────────┤                      │
│ golang.org/x/net    │ CVE-2024-45338 │ HIGH     │              │ vulnerable_code_not_in_execute_path │                      │
└─────────────────────┴────────────────┴──────────┴──────────────┴─────────────────────────────────────┴──────────────────────┘

bin/runc (gobinary)
===================
Total: 0 (HIGH: 0, CRITICAL: 0)


Suppressed Vulnerabilities (Total: 1)
=====================================
┌──────────────────┬────────────────┬──────────┬──────────────┬─────────────────────────────┬──────────────────────┐
│     Library      │ Vulnerability  │ Severity │    Status    │          Statement          │        Source        │
├──────────────────┼────────────────┼──────────┼──────────────┼─────────────────────────────┼──────────────────────┤
│ golang.org/x/net │ CVE-2024-45338 │ HIGH     │ not_affected │ vulnerable_code_not_present │ rancher.openvex.json │
└──────────────────┴────────────────┴──────────┴──────────────┴─────────────────────────────┴──────────────────────┘

@brandond brandond marked this pull request as draft January 22, 2025 20:10
@brandond brandond marked this pull request as ready for review January 22, 2025 22:40
Signed-off-by: Brad Davidson <[email protected]>
@@ -232,29 +230,52 @@ func (c *Config) Start(ctx context.Context, nodeConfig *config.Node) error {
return err
}
mRouter.PathPrefix("/v2").Handler(regSvr.Handler)
mRouter.PathPrefix("/v1-" + version.Program + "/p2p").Handler(c.peerInfo())
mRouter.PathPrefix("/v1-{program}/p2p").Handler(c.peerInfo())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this program value inject internally in Spegel now?

Copy link
Member Author

@brandond brandond Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just our route to the handler that returns the address list that is used by our custom agent bootstrapper. I missed this one when switching to {program} in the prefix for other routes in #11471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants